home *** CD-ROM | disk | FTP | other *** search
/ Internet Info 1994 March / Internet Info CD-ROM (Walnut Creek) (March 1994).iso / networking / info-service / wais / wais-8-b5.1-swais-patches < prev    next >
Encoding:
Internet Message Format  |  1993-02-26  |  3.4 KB
  1. From jonathan@Think.COM Wed Dec  2 16:14:17 1992
  2. Date: Wed, 2 Dec 92 09:59:00 PST
  3. From: Jonny Goldman <jonathan@Think.COM>
  4. To: wais-talk@Think.COM
  5. Cc: bug-wais@Think.COM
  6. Subject: bugs in b5.1 swais
  7.  
  8.  
  9. There are two bugs in the b5.1 version of swais that make it unusable.
  10.  
  11. The first bug caused a segmentation fault the first time a status message
  12. was printed if the code was compiled with a non-ANSI compiler (Sun's cc,
  13. for instance).  The second bug prevented any useful results  from being
  14. returned (as the number of documents requested was 0!).
  15.  
  16. Here's a context diff for the code:
  17.  
  18. *** screen-ui.c~    Sun Jul 12 14:10:25 1992
  19. --- screen-ui.c    Wed Dec  2 09:34:14 1992
  20. ***************
  21. *** 267,272 ****
  22. --- 267,273 ----
  23.     long logtype, loglevel;
  24.     char *format;
  25.   
  26. +   va_start(ap);
  27.     logtype = va_arg(ap, int);
  28.     loglevel = va_arg(ap, int);
  29.     format = va_arg(ap, char*);
  30. ***************
  31. *** 1044,1049 ****
  32. --- 1045,1051 ----
  33.       question->ResultDocuments = NULL;
  34.       question->numresdocs = listlength((List)question->ResultDocuments);
  35.   
  36. +     question->maxresdocs = *options[6].var.intptr;
  37.       SearchWais(question);
  38.       question->modified = FALSE;
  39.   
  40.  
  41. - Jonny G
  42. From owner-wais-talk@quake.think.com Thu Dec  3 18:50:38 1992
  43. Received: from quake.think.com by SunSite.unc.edu (4.1/TAS/11-16-88)
  44.     id AA06799; Thu, 3 Dec 92 18:50:35 EST
  45. Received: by quake.think.com (4.1/SMI-4.0)
  46.     id AA10347; Thu, 3 Dec 92 13:48:44 PST
  47. Return-Path: <jonathan@philo.quake.think.com>
  48. Received: from mail.think.com by quake.think.com (4.1/SMI-4.0)
  49.     id AA09875; Thu, 3 Dec 92 13:47:55 PST
  50. Received: from Think.COM by mail.think.com; Thu, 3 Dec 92 16:46:51 -0500
  51. Received: from quake.think.com by Early-Bird.Think.COM; Thu, 3 Dec 92 16:46:40 EST
  52. Received: from philo.quake.think.com by quake.think.com (4.1/SMI-4.0)
  53.     id AA09175; Thu, 3 Dec 92 13:46:44 PST
  54. Received: by philo.quake.think.com (4.1/SMI-4.1)
  55.     id AA00624; Thu, 3 Dec 92 13:43:37 PST
  56. Date: Thu, 3 Dec 92 13:43:37 PST
  57. Message-Id: <9212032143.AA00624@philo.quake.think.com>
  58. From: Jonny Goldman <jonathan@Think.COM>
  59. Sender: jonathan@philo.quake.think.com
  60. To: wais-talk@Think.COM
  61. Cc: bug-wais@Think.COM
  62. Subject: another bug in b5.1 swais
  63. Status: R
  64.  
  65. There's another bug in the b5.1 swais.  This has to do with handling
  66. document types.  This is relative to the patch I posted yesterday.
  67.  
  68. === diff screen-ui.c~ screen-ui.c ===
  69. *** /proj/wais/wais-8-b5.1/ui/screen-ui.c~    Wed Dec  2 09:34:14 1992
  70. --- /proj/wais/wais-8-b5.1/ui/screen-ui.c    Thu Dec  3 13:24:35 1992
  71. ***************
  72. *** 372,374 ****
  73.   
  74. !     if (strcmp(doc->doc->type, "WSRC")) {
  75.           fprintf(stderr, "%s", "%s is not a WAIS source.  You can only USE WAIS sources.",
  76. --- 372,374 ----
  77.   
  78. !     if ((doc->doc->type == NULL) || strcmp(doc->doc->type[0], "WSRC") != 0) {
  79.           fprintf(stderr, "%s", "%s is not a WAIS source.  You can only USE WAIS sources.",
  80. ***************
  81. *** 808,811 ****
  82.           mvprintw(j++,0,"%s\t%s","Industry:   ",current_doc->doc->industry);
  83. !     if (NULL != current_doc->doc->type) 
  84. !         mvprintw(j++,0,"%s\t%s","Type:       ",current_doc->doc->type);
  85.       mvprintw(j++,0,"%s\t%d","Score       ",current_doc->rawScore);
  86. --- 808,811 ----
  87.           mvprintw(j++,0,"%s\t%s","Industry:   ",current_doc->doc->industry);
  88. !     if ((NULL != current_doc->doc->type) && current_doc->doc->type[0] != NULL)
  89. !         mvprintw(j++,0,"%s\t%s","Type:       ",current_doc->doc->type[0]);
  90.       mvprintw(j++,0,"%s\t%d","Score       ",current_doc->rawScore);
  91.  
  92.  
  93.